Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

Issue 312673006: Added a policy to control the visibility of the apps shortcut. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
index f51d1dbefdb6f1e6e46feeff4683168ac72a8b2b..66b6367736b57998bb99c6502063ba2727f00dcf 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
@@ -15,6 +15,7 @@
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_pref_service_syncable.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "ui/views/controls/button/text_button.h"
@@ -70,3 +71,31 @@ TEST_F(BookmarkBarViewInstantExtendedTest, AppsShortcutVisibility) {
prefs::kShowAppsShortcutInBookmarkBar, false);
EXPECT_FALSE(bookmark_bar_view.apps_page_shortcut_->visible());
}
+
+// Verifies that the apps shortcut is shown or hidden following the policy
+// value.
+TEST_F(BookmarkBarViewInstantExtendedTest,
sky 2014/06/03 16:15:07 Your test has nothing to do with instant, so makin
Joao da Silva 2014/06/03 22:20:52 Done.
+ ManagedShowAppsShortcutInBookmarksBar) {
+ ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal());
+ profile()->CreateBookmarkModel(true);
+ test::WaitForBookmarkModelToLoad(
+ BookmarkModelFactory::GetForProfile(profile()));
+ BookmarkBarView bookmark_bar_view(browser(), NULL);
+ bookmark_bar_view.set_owned_by_client();
+
+ // By default the pref is not managed and the apps shortcut is shown.
+ TestingPrefServiceSyncable* prefs = profile()->GetTestingPrefService();
+ EXPECT_FALSE(
+ prefs->IsManagedPreference(prefs::kShowAppsShortcutInBookmarkBar));
+ EXPECT_TRUE(bookmark_bar_view.apps_page_shortcut_->visible());
+
+ // Hide the apps shortcut by policy, via the managed pref.
+ prefs->SetManagedPref(prefs::kShowAppsShortcutInBookmarkBar,
+ new base::FundamentalValue(false));
+ EXPECT_FALSE(bookmark_bar_view.apps_page_shortcut_->visible());
+
+ // And try showing it via policy too.
+ prefs->SetManagedPref(prefs::kShowAppsShortcutInBookmarkBar,
+ new base::FundamentalValue(true));
+ EXPECT_TRUE(bookmark_bar_view.apps_page_shortcut_->visible());
+}

Powered by Google App Engine
This is Rietveld 408576698