Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 312623003: Convert Sync enable/disable test to use FakeServer (Closed)

Created:
6 years, 6 months ago by pval...(no longer on Chromium)
Modified:
6 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Convert Sync enable/disable test to use FakeServer BUG=323265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274663

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M chrome/browser/sync/test/integration/enable_disable_test.cc View 5 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pval...(no longer on Chromium)
6 years, 6 months ago (2014-06-03 00:13:56 UTC) #1
rlarocque
lgtm
6 years, 6 months ago (2014-06-03 00:16:28 UTC) #2
pval...(no longer on Chromium)
The CQ bit was checked by pvalenzuela@chromium.org
6 years, 6 months ago (2014-06-03 16:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/312623003/20001
6 years, 6 months ago (2014-06-03 16:50:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 19:52:17 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 23:05:42 UTC) #6
Message was sent while issue was closed. 
Change committed as 274663

Powered by Google App Engine
This is Rietveld 408576698