Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: components/metrics/metrics_pref_names.h

Issue 312583002: Move MetricsStateManager into the Metrics component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_pref_names.h
diff --git a/components/metrics/metrics_pref_names.h b/components/metrics/metrics_pref_names.h
index 4c799c7d5f26e7cb3bb3a7021dbaaeb95a3ea35b..ea03ec20057e59dc250d59e84ffae296b0917289 100644
--- a/components/metrics/metrics_pref_names.h
+++ b/components/metrics/metrics_pref_names.h
@@ -9,7 +9,14 @@ namespace metrics {
namespace prefs {
// Alphabetical list of preference names specific to the metrics
-// component. Keep alphabetized, and document each in the .cc file.
+// component. Document each in the .cc file.
Alexei Svitkine (slow) 2014/06/02 20:35:43 Not keeping them alphabetical is fine, but let's g
blundell 2014/06/02 20:43:41 I actually prefer having them be alphabetical (as
Alexei Svitkine (slow) 2014/06/02 20:51:44 Sure. I don't think the grouping is super importan
blundell 2014/06/03 15:46:48 Done.
+extern const char kMetricsClientID[];
+extern const char kMetricsSessionID[];
+extern const char kMetricsLowEntropySource[];
+extern const char kMetricsOldClientID[];
+extern const char kMetricsOldLowEntropySource[];
+extern const char kMetricsReportingEnabled[];
+extern const char kMetricsReportingEnabledTimestamp[];
extern const char kMetricsInitialLogs[];
extern const char kMetricsMachineId[];
extern const char kMetricsOngoingLogs[];

Powered by Google App Engine
This is Rietveld 408576698