Land Recent QUIC Changes.

Land Recent QUIC Changes.

Ensuring that QUIC's pacing sender can have TimeUntilSend called
multiple times and behave return the same time to send.

Also add more tests to ensure the pacing sender properly makes up for
lost time, but stops doing so after application limited sending.

Merge internal change: 68257669
https://codereview.chromium.org/312573002/


Drop "Interface" from name of QUIC debug interfaces that should not be
abstract.

Drop Interface from some class names.

Merge internal change: 68257565
https://codereview.chromium.org/310693002/


QUIC flow control now based on highest received byte offset rather than
bytes buffered. No longer keep track of how many bytes we have buffered
in the QUIC flow controller - this adds complexity when we can just
track the highest received byte offset. This allows us to detect flow
control violation earlier.

QUIC flow control now based on highest received byte offset rather than
bytes buffered. Protected behind (already ENABLEd)
FLAGS_enable_quic_stream_flow_control_2

Merge internal change: 68200399
https://codereview.chromium.org/305033011/


Changes the pacing sender's alarm granularity from 1 microsecond to 5
milliseconds.

Merge internal change: 68197640
https://codereview.chromium.org/302283004/


Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always
try sending a WINDOW_UPDATE from inside AddBytesConsumed. Whenever
bytes_consumed changes we may want to send a WINDOW_UPDATE, and this CL
prevents future users calling AddBytesConsumed and forgetting
MaybeSendWindowUpdate.

QUIC: remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream

Merge internal change: 68188106
https://codereview.chromium.org/308363002/


Remove the TransmissionType argument from QuicConnection CanWrite and
SentPacketManager TimeUntilSend by generalizing the
QuicSentPackeManager's TLP alarm.

Merge internal change: 68148420
https://codereview.chromium.org/306013009/


Cleanup in QuicConnection to always cancel the send alarm when CanWrite
is consulted and use CanWrite when deciding to send in response to a
packet receipt.

Merge internal change: 68118973
https://codereview.chromium.org/304293009/


Allow QUIC's BBR congestion control to be negotiated in the crypto
handshake.

Adding an implementation of QuicFixedTagVector to QuicConfig to enable
multiple congestion control options per connection.

Merge internal change: 68114869
https://codereview.chromium.org/308273004/


Move test-only method from QuicFramer to quic_test_utils.

Merge internal change: 68110215
https://codereview.chromium.org/305343002/


Replaced options from QuicPacketCreator with members and explicit
getters/setters. A couple of small bugs fixed.

Merge internal change: 68099048
https://codereview.chromium.org/301173007/

R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274455

[ramant (doing other things), 2014-06-02 22:27:01]

On 2014/06/02 20:11:36, ramant wrote:

Hi Ryan,
 Would like to submit the quic_types.[h,cc] changes of the following CL in
another CL (after getting OK from wtc). 

 https://codereview.chromium.org/309013006/

 This landing CL includes all the changes you have already LGTM'ed and doesn't
include the above CL.

thanks
raman

[Ryan Hamilton, 2014-06-02 22:41:42]

lgtm

[ramant (doing other things), 2014-06-02 22:46:19]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-06-02 22:47:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/312553003/1

[commit-bot: I haz the power, 2014-06-03 10:20:31]

Change committed as 274455