Rename GCMStatsRecorder to GCMStatsRecorderImpl

Rename GCMStatsRecorder to GCMStatsRecorderImpl

We also add the interface using the old name GCMStatsRecorder.

This is in preparation to move GCMClient to gcm_driver component.
We're going to move GCMActivity, GCMClient, GCMClientImpl, and
GCMStatsRecorderImpl to gcm_driver component while keeping
GCMStatsRecorder interface in google_apis/gcm.

BUG=356716
TEST=existing tests due to no functionality changes
R=juyik@chromium.org, zea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274641

[juyik, 2014-06-02 19:19:03]

https://codereview.chromium.org/312553002/diff/20001/google_apis/gcm/monitori...
File google_apis/gcm/monitoring/gcm_stats_recorder.h (right):

https://codereview.chromium.org/312553002/diff/20001/google_apis/gcm/monitori...
google_apis/gcm/monitoring/gcm_stats_recorder.h:5: #ifndef
GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECODER_H_
RECODER -> RECORDER
Same below.

[jianli, 2014-06-02 19:46:30]

https://codereview.chromium.org/312553002/diff/20001/google_apis/gcm/monitori...
File google_apis/gcm/monitoring/gcm_stats_recorder.h (right):

https://codereview.chromium.org/312553002/diff/20001/google_apis/gcm/monitori...
google_apis/gcm/monitoring/gcm_stats_recorder.h:5: #ifndef
GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECODER_H_
On 2014/06/02 19:19:04, juyik wrote:
> RECODER -> RECORDER
> Same below.

Done.

[juyik, 2014-06-03 00:53:58]

lgtm

[Nicolas Zea, 2014-06-03 17:53:06]

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
File google_apis/gcm/monitoring/fake_gcm_stats_recorder.h (right):

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
google_apis/gcm/monitoring/fake_gcm_stats_recorder.h:12: class
FakeGCMStatsRecorder : public GCMStatsRecorder {
nit: Comment what this class does

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
File google_apis/gcm/monitoring/gcm_stats_recorder_impl.h (left):

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
google_apis/gcm/monitoring/gcm_stats_recorder_impl.h:39: class Delegate {
Shouldn't the delegate be in the public interface?

[jianli, 2014-06-03 18:00:07]

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
File google_apis/gcm/monitoring/fake_gcm_stats_recorder.h (right):

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
google_apis/gcm/monitoring/fake_gcm_stats_recorder.h:12: class
FakeGCMStatsRecorder : public GCMStatsRecorder {
On 2014/06/03 17:53:06, Nicolas Zea wrote:
> nit: Comment what this class does

Done.

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
File google_apis/gcm/monitoring/gcm_stats_recorder_impl.h (left):

https://codereview.chromium.org/312553002/diff/40001/google_apis/gcm/monitori...
google_apis/gcm/monitoring/gcm_stats_recorder_impl.h:39: class Delegate {
On 2014/06/03 17:53:06, Nicolas Zea wrote:
> Shouldn't the delegate be in the public interface?

Done.

[Nicolas Zea, 2014-06-03 18:43:15]

lgtm

[jianli, 2014-06-03 19:54:05]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-03 19:55:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/312553002/60001

[jianli, 2014-06-03 20:57:55]

The CQ bit was unchecked by jianli@chromium.org

[jianli, 2014-06-03 21:01:51]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-03 21:02:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/312553002/60001

[jianli, 2014-06-03 21:51:24]

Committed patchset #4 manually as r274641 (presubmit successful).