Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 312523003: MacViews: Implement a ui::InputMethod for Mac (Closed)

Created:
6 years, 6 months ago by Andre
Modified:
6 years, 6 months ago
Reviewers:
Yuki
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org, mac-views-reviews_chromium.org
Visibility:
Public.

Description

MacViews: Implement a ui::InputMethod for Mac Add InputMethodMac class and update InputMethodFactory to create it. It doesn't do anything for now. We plan to bridge NSTextInputClient calls directly to the focused ui::TextInputClient object. BUG=374077 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274636

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
M ui/base/ime/ime.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A + ui/base/ime/input_method_mac.h View 2 chunks +12 lines, -10 lines 0 comments Download
A ui/base/ime/input_method_mac.mm View 1 chunk +49 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Andre
Yuki, PTAL. This is the first piece I'd like to land, more coming later as ...
6 years, 6 months ago (2014-06-02 21:22:42 UTC) #1
Yuki
lgtm https://codereview.chromium.org/312523003/diff/20001/ui/base/ime/input_method_mac.mm File ui/base/ime/input_method_mac.mm (right): https://codereview.chromium.org/312523003/diff/20001/ui/base/ime/input_method_mac.mm#newcode41 ui/base/ime/input_method_mac.mm:41: return true; I'm not sure if you really ...
6 years, 6 months ago (2014-06-03 07:50:15 UTC) #2
Andre
https://codereview.chromium.org/312523003/diff/20001/ui/base/ime/input_method_mac.mm File ui/base/ime/input_method_mac.mm (right): https://codereview.chromium.org/312523003/diff/20001/ui/base/ime/input_method_mac.mm#newcode41 ui/base/ime/input_method_mac.mm:41: return true; On 2014/06/03 07:50:15, Yuki wrote: > I'm ...
6 years, 6 months ago (2014-06-03 17:55:03 UTC) #3
Andre
The CQ bit was checked by andresantoso@chromium.org
6 years, 6 months ago (2014-06-03 17:55:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/312523003/20001
6 years, 6 months ago (2014-06-03 17:55:41 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:36:29 UTC) #6
Message was sent while issue was closed.
Change committed as 274636

Powered by Google App Engine
This is Rietveld 408576698