Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 312503006: Add trace event for addition/removal of GPU rasterization trigger (Closed)

Created:
6 years, 6 months ago by ajuma
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org, jam, darin-cc_chromium.org, alokp, Vangelis Kokkevis
Visibility:
Public.

Description

Add trace event for addition/removal of GPU rasterization trigger This records a trace event whenver the viewport-based GPU rasterization trigger is added or removed. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274664

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
ajuma
6 years, 6 months ago (2014-06-02 18:48:02 UTC) #1
ernstm
https://codereview.chromium.org/312503006/diff/1/cc/trees/layer_tree_host.cc File cc/trees/layer_tree_host.cc (right): https://codereview.chromium.org/312503006/diff/1/cc/trees/layer_tree_host.cc#newcode628 cc/trees/layer_tree_host.cc:628: TRACE_EVENT_INSTANT0( Could you issue a TRACE_EVENT_INSTANT1 with name "LayerTreeHost::SetHasGpuRasterizationTrigger" ...
6 years, 6 months ago (2014-06-02 21:34:48 UTC) #2
alokp
lgtm % ernstm
6 years, 6 months ago (2014-06-02 23:14:56 UTC) #3
ajuma
PTAL. https://codereview.chromium.org/312503006/diff/1/cc/trees/layer_tree_host.cc File cc/trees/layer_tree_host.cc (right): https://codereview.chromium.org/312503006/diff/1/cc/trees/layer_tree_host.cc#newcode628 cc/trees/layer_tree_host.cc:628: TRACE_EVENT_INSTANT0( On 2014/06/02 21:34:48, ernstm wrote: > Could ...
6 years, 6 months ago (2014-06-03 14:47:10 UTC) #4
ernstm1
On 2014/06/03 14:47:10, ajuma wrote: > PTAL. > > https://codereview.chromium.org/312503006/diff/1/cc/trees/layer_tree_host.cc > File cc/trees/layer_tree_host.cc (right): > ...
6 years, 6 months ago (2014-06-03 16:33:55 UTC) #5
ajuma
TBR=kbr for mechanical change to render_widget_compositor.cc (changing a call to match the function's renaming in ...
6 years, 6 months ago (2014-06-03 16:57:15 UTC) #6
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 6 months ago (2014-06-03 16:57:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/312503006/20001
6 years, 6 months ago (2014-06-03 16:58:51 UTC) #8
Ken Russell (switch to Gerrit)
LGTM FWIW
6 years, 6 months ago (2014-06-03 17:23:21 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 18:43:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 20:54:10 UTC) #11
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 6 months ago (2014-06-03 23:09:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/312503006/20001
6 years, 6 months ago (2014-06-03 23:11:05 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 23:13:06 UTC) #14
Message was sent while issue was closed.
Change committed as 274664

Powered by Google App Engine
This is Rietveld 408576698