Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Chromium Code Reviews
Help
|
Chromium Project
|
Sign in
(15)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
3125003
: Remove a bunch of extra includes. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by
vandebo (ex-Chrome)
Modified:
4 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.
Description
Remove a bunch of extra includes. BUG=extra includes TEST=still compiles Committed:
http://src.chromium.org/viewvc/chrome?view=rev&revision=55638
Patch Set 1
#
Created:
4 years, 9 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+20 lines, -11 lines
)
Patch
M
net/http/http_proxy_client_socket_pool.h
View
1 chunk
+3 lines, -3 lines
0 comments
Download
M
net/http/http_proxy_client_socket_pool.cc
View
1 chunk
+1 line, -0 lines
0 comments
Download
M
net/socket/socks_client_socket_pool.h
View
1 chunk
+2 lines, -2 lines
0 comments
Download
M
net/socket/socks_client_socket_pool.cc
View
1 chunk
+1 line, -0 lines
0 comments
Download
M
net/socket/ssl_client_socket_pool.h
View
1 chunk
+8 lines, -6 lines
0 comments
Download
M
net/socket/ssl_client_socket_pool.cc
View
1 chunk
+5 lines, -0 lines
0 comments
Download
Trybot results:
mac
linux
win
More>>>
<<<Less
Commit:
CQ not working?
Messages
Total messages: 2 (0 generated)
Expand Messages
|
Collapse Messages
vandebo (ex-Chrome)
4 years, 9 months ago (2010-08-10 22:49:23 UTC)
#1
Sign in
to reply to this message.
Evan Stade
lgtm
4 years, 9 months ago (2010-08-10 23:38:28 UTC)
#2
lgtm
Sign in
to reply to this message.
Expand Messages
|
Collapse Messages
Issue 3125003: Remove a bunch of extra includes. (Closed)
Created 4 years, 9 months ago by vandebo (ex-Chrome)
Modified 4 years ago
Reviewers: Evan Stade
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
ec887be