Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 312483002: More accelerator code leanup (Closed)

Created:
6 years, 6 months ago by oshima
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

More accelerator code leanup * Remove null check * Simplify NestedAcceleratorDelegate interface. BUG=None R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274560

Patch Set 1 : #

Patch Set 2 : fix test #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -68 lines) Patch
M ash/accelerators/accelerator_delegate.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/accelerators/nested_accelerator_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/nested_accelerator_delegate.cc View 3 chunks +23 lines, -24 lines 0 comments Download
M ui/wm/core/accelerator_filter.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/wm/core/accelerator_filter.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M ui/wm/core/nested_accelerator_controller_unittest.cc View 1 1 chunk +4 lines, -11 lines 0 comments Download
M ui/wm/core/nested_accelerator_delegate.h View 2 chunks +11 lines, -8 lines 0 comments Download
M ui/wm/core/nested_accelerator_dispatcher_linux.cc View 2 chunks +13 lines, -7 lines 0 comments Download
M ui/wm/core/nested_accelerator_dispatcher_win.cc View 1 2 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
oshima
6 years, 6 months ago (2014-06-02 23:25:12 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-02 23:53:33 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-03 00:15:01 UTC) #3
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 6 months ago (2014-06-03 00:15:01 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-03 00:15:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/312483002/20001
6 years, 6 months ago (2014-06-03 00:17:00 UTC) #6
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 6 months ago (2014-06-03 00:55:13 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-03 00:59:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/312483002/40001
6 years, 6 months ago (2014-06-03 01:01:02 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 04:42:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 05:06:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/15182)
6 years, 6 months ago (2014-06-03 05:06:08 UTC) #12
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-03 10:16:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/312483002/60001
6 years, 6 months ago (2014-06-03 10:20:56 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 14:04:51 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 16:58:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/22992)
6 years, 6 months ago (2014-06-03 16:58:05 UTC) #17
oshima
On 2014/06/03 16:58:05, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-03 17:09:15 UTC) #18
oshima
6 years, 6 months ago (2014-06-03 17:17:11 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 manually as r274560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698