Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 312463002: Revert of Mojo: Specify/check alignment of pointers more carefully. (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Revert of Mojo: Specify/check alignment of pointers more carefully. (https://codereview.chromium.org/304303006/) Reason for revert: Broke the windows bots: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40269 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26580 Original issue's description: > Mojo: Specify/check alignment of pointers more carefully. > > Improve the verification routines especially in the case that no count > is necessary. > > Also add a test. > > R=darin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273936 TBR=darin@chromium.org,viettrungluu@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -258 lines) Patch
M mojo/mojo.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/system/core.cc View 9 chunks +24 lines, -27 lines 0 comments Download
M mojo/system/core_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/data_pipe_producer_dispatcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/memory.h View 1 chunk +22 lines, -31 lines 0 comments Download
M mojo/system/memory.cc View 1 chunk +8 lines, -46 lines 0 comments Download
D mojo/system/memory_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaleCurtis
Created Revert of Mojo: Specify/check alignment of pointers more carefully.
6 years, 6 months ago (2014-05-31 22:06:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/312463002/1
6 years, 6 months ago (2014-05-31 22:07:34 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 22:09:02 UTC) #3
Message was sent while issue was closed.
Change committed as 274062

Powered by Google App Engine
This is Rietveld 408576698