chrome/browser/chromeos/preferences.cc - Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/ui/login_display_host_impl.cc ('K') | « chrome/browser/chromeos/login/ui/login_display_host_impl.cc ('k') | chromeos/ime/input_method_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/preferences.cc

diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc

index d3a74ff3e546361a8589ac03a67ac548ce6d9a3b..2fa7fe0520a9bd6d19ff8e7c25bcc93a41fed289 100644

--- a/chrome/browser/chromeos/preferences.cc

+++ b/chrome/browser/chromeos/preferences.cc

@@ -584,10 +584,8 @@ void Preferences::SetLanguageConfigStringListAsCSV(const char* section,

if (!value.empty())

base::SplitString(value, ',', &split_values);

- // TODO(shuchen): migration of the xkb id to extension-xkb id.

- // Remove this function after few milestones are passed.

- // See: http://crbug.com/345604

- if (input_method_manager_->MigrateXkbInputMethods(&split_values))

+ // Transfers the xkb id to extension-xkb id.

+ if (input_method_manager_->MigrateInputMethods(&split_values))

preload_engines_.SetValue(JoinString(split_values, ','));

if (section == std::string(language_prefs::kGeneralSectionName) &&