Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 312443002: Updates the whitelisted XKB input method IDs to sync up with the component XKB extension. (Closed)

Created:
6 years, 6 months ago by Shu Chen
Modified:
6 years, 6 months ago
Reviewers:
satorux1
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Updates the whitelisted XKB input method IDs to sync up with the component XKB extension. Obsolete input methods are deleted. And makes sure there won't be duplicated input methods for certain languages. BUG=379434 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274226

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : sorted ids and obsolete input methodsdeleted. #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -53 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 3 4 5 6 2 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 2 chunks +5 lines, -1 line 0 comments Download
M chromeos/ime/input_methods.txt View 1 2 5 chunks +29 lines, -21 lines 0 comments Download
M tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py View 1 2 3 3 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Shu Chen
Satoru, can you please review this cl? Thanks
6 years, 6 months ago (2014-05-31 08:48:54 UTC) #1
satorux1
https://codereview.chromium.org/312443002/diff/40001/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py File tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py (left): https://codereview.chromium.org/312443002/diff/40001/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py#oldcode105 tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py:105: 'pinyin-dv': 'en_US_dvorak', please mention that obsolete input methods are ...
6 years, 6 months ago (2014-06-02 03:29:49 UTC) #2
Shu Chen
https://codereview.chromium.org/312443002/diff/40001/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py File tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py (left): https://codereview.chromium.org/312443002/diff/40001/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py#oldcode105 tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py:105: 'pinyin-dv': 'en_US_dvorak', On 2014/06/02 03:29:49, satorux1 wrote: > please ...
6 years, 6 months ago (2014-06-02 03:33:26 UTC) #3
satorux1
lgtm
6 years, 6 months ago (2014-06-02 03:48:14 UTC) #4
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-02 04:04:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/312443002/60001
6 years, 6 months ago (2014-06-02 04:04:36 UTC) #6
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-02 09:29:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/312443002/120001
6 years, 6 months ago (2014-06-02 09:30:05 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 13:50:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 274226

Powered by Google App Engine
This is Rietveld 408576698