Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: components/breakpad/browser/crash_dump_manager_android.h

Issue 31243002: Move Linux/Android breakpad implementation to breakpad component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/breakpad/browser/DEPS ('k') | components/breakpad/browser/crash_dump_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/breakpad/browser/crash_dump_manager_android.h
diff --git a/chrome/browser/android/crash_dump_manager.h b/components/breakpad/browser/crash_dump_manager_android.h
similarity index 90%
rename from chrome/browser/android/crash_dump_manager.h
rename to components/breakpad/browser/crash_dump_manager_android.h
index 9b0438ef4b0ef42cd6666c6d6bf0ff9955af4a15..9420dafd16c3478d2bb144a40581a171718d4486 100644
--- a/chrome/browser/android/crash_dump_manager.h
+++ b/components/breakpad/browser/crash_dump_manager_android.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
-#define CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
+#ifndef COMPONENTS_BREAKPAD_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
+#define COMPONENTS_BREAKPAD_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
#include <map>
@@ -19,6 +19,8 @@ namespace content {
class RenderProcessHost;
}
+namespace breakpad {
+
// This class manages the crash minidumps.
// On Android, because of process isolation, each renderer process runs with a
// different UID. As a result, we cannot generate the minidumps in the browser
@@ -31,10 +33,12 @@ class RenderProcessHost;
class CrashDumpManager : public content::BrowserChildProcessObserver,
public content::NotificationObserver {
public:
- // This object is a singleton created and owned by the
- // ChromeBrowserMainPartsAndroid.
+ // The embedder should create a single instance of the CrashDumpManager.
static CrashDumpManager* GetInstance();
+ // Should be created on the UI thread.
+ explicit CrashDumpManager(const base::FilePath& crash_dump_dir);
+
virtual ~CrashDumpManager();
// Returns a file descriptor that should be used to generate a minidump for
@@ -42,11 +46,6 @@ class CrashDumpManager : public content::BrowserChildProcessObserver,
int CreateMinidumpFile(int child_process_id);
private:
- friend class ChromeBrowserMainPartsAndroid;
-
- // Should be created on the UI thread.
- explicit CrashDumpManager(const base::FilePath& crash_dump_dir);
-
typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
static void ProcessMinidump(const base::FilePath& minidump_path,
@@ -80,4 +79,6 @@ class CrashDumpManager : public content::BrowserChildProcessObserver,
DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
};
-#endif // CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
+} // namespace breakpad
+
+#endif // COMPONENTS_BREAKPAD_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
« no previous file with comments | « components/breakpad/browser/DEPS ('k') | components/breakpad/browser/crash_dump_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698