Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/chrome_browser.gypi

Issue 31243002: Move Linux/Android breakpad implementation to breakpad component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 27fddf5b8af2a05189ca795b519a92b2f565f60b..84740d5259e805f2d9804a1a6a8314220196f6c1 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -103,8 +103,6 @@
'browser/android/chromium_application.h',
'browser/android/content_view_util.cc',
'browser/android/content_view_util.h',
- 'browser/android/crash_dump_manager.cc',
- 'browser/android/crash_dump_manager.h',
'browser/android/dev_tools_server.cc',
'browser/android/dev_tools_server.h',
'browser/android/favicon_helper.cc',
@@ -3031,23 +3029,12 @@
}],
['os_posix == 1 and OS != "mac" and OS != "ios"', {
'sources': [
- 'app/breakpad_linux.cc',
- 'app/breakpad_linux.h',
'app/chrome_breakpad_client.cc',
'app/chrome_breakpad_client.h',
- 'browser/crash_handler_host_linux.cc',
- 'browser/crash_handler_host_linux.h',
],
'dependencies': [
- '../breakpad/breakpad.gyp:breakpad_client',
'../components/components.gyp:breakpad_component',
- # make sure file_version_info_linux.h is generated first.
- 'common',
- ],
- 'include_dirs': [
- # breakpad_linux.cc uses generated file_version_info_linux.h.
- '<(SHARED_INTERMEDIATE_DIR)',
- '../breakpad/src',
+ '../components/components.gyp:breakpad_host',
],
}],
['use_nss==1', {
@@ -3496,16 +3483,6 @@
]
}]
],
- 'target_conditions': [
- # Need 'target_conditions' to override default filename_rules to include
- # the files on Android.
- ['OS=="android"', {
- 'sources/': [
- ['include', '^app/breakpad_linux\\.cc$'],
- ['include', '^browser/crash_handler_host_linux\\.cc$'],
- ],
- }],
- ],
},
{
# Protobuf compiler / generator for the fraudulent certificate reporting

Powered by Google App Engine
This is Rietveld 408576698