Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 312423004: Enable app info dialog by default. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Enable app info dialog by default. This dialog is very usable and is ready to be enabled by default to get wider exposure. BUG=266739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275679

Patch Set 1 #

Patch Set 2 : Browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_views_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/app_list_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_switches.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
benwells
6 years, 6 months ago (2014-06-06 06:30:16 UTC) #1
tapted
lgtm!
6 years, 6 months ago (2014-06-06 06:34:08 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-06 06:53:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/312423004/1
6 years, 6 months ago (2014-06-06 06:54:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 12:01:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 12:40:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/24824)
6 years, 6 months ago (2014-06-06 12:40:33 UTC) #7
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-07 10:32:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/312423004/20001
6 years, 6 months ago (2014-06-07 10:33:03 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 11:52:18 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 14:26:24 UTC) #11
Message was sent while issue was closed.
Change committed as 275679

Powered by Google App Engine
This is Rietveld 408576698