chrome/browser/autocomplete/shortcuts_provider.h - Issue 312423003: Cleanup AutocompleteInput and AutocompleteProvider Functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/shortcuts_provider.h

Issue 312423003: Cleanup AutocompleteInput and AutocompleteProvider Functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Return a std::pair Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/shortcuts_provider.h

diff --git a/chrome/browser/autocomplete/shortcuts_provider.h b/chrome/browser/autocomplete/shortcuts_provider.h

index 754e87252cbe5ab2d62d662d33ebe0932d9a668f..516d67e9bcea4be8854aae5e314bd8bbcafae4eb 100644

--- a/chrome/browser/autocomplete/shortcuts_provider.h

+++ b/chrome/browser/autocomplete/shortcuts_provider.h

@@ -52,13 +52,13 @@ class ShortcutsProvider

// Returns an AutocompleteMatch corresponding to |shortcut|. Assigns it

// |relevance| score in the process, and highlights the description and

// contents against |input|, which should be the lower-cased version

- // of the user's input. |input|, |fixed_up_input|, and

+ // of the user's input. |input|, |fixed_up_input_text|, and

// |input_as_gurl| are used to decide what can be inlined.

AutocompleteMatch ShortcutToACMatch(

const history::ShortcutsDatabase::Shortcut& shortcut,

int relevance,

const AutocompleteInput& input,

- const AutocompleteInput& fixed_up_input,

+ const base::string16& fixed_up_input_text,

const GURL& input_as_gurl);

// Returns a map mapping characters to groups of words from |text| that start