Cleanup AutocompleteInput and AutocompleteProvider Functions

Cleanup AutocompleteInput and AutocompleteProvider Functions

* Make FixupUserInput() just return the fixed-up input text, since almost every
  caller wanted that (and the one that didn't, the HUP, will change in the
  future)
* Make some functions which took an AutocompleteInput object and then only cared
  about the text() just take a string16
* Eliminated HistoryURLProvider::RunAutocompletePasses(), since it had only one
  caller, and just inline the code into Start().  Also got rid of the
  |fixup_input_and_run_pass_1| variable that was never false.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275540

[Peter Kasting, 2014-06-06 07:13:59]

I think I can make this even simpler by changing the signature of
FixupUserInput() to return a string16; I'll take a shot at this in the morning.

[Peter Kasting, 2014-06-06 17:33:21]

Now ready for a look.

[Mark P, 2014-06-06 17:46:42]

Okay.  Your changelist description is now slightly out-of-date.

--mark


On Fri, Jun 6, 2014 at 10:33 AM, <pkasting@chromium.org> wrote:

> Now ready for a look.
>
> https://codereview.chromium.org/312423003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Kasting, 2014-06-06 17:53:02]

On 2014/06/06 17:46:42, Mark P wrote:
> Okay.  Your changelist description is now slightly out-of-date.

I added a word to it, but I didn't tweak it beyond that, since I don't think
it's necessary to detail things like the new bool arg in the CL description (too
low-level of a detail).

[Mark P, 2014-06-06 18:06:59]

On Thu, Jun 5, 2014 at 6:44 PM, <pkasting@chromium.org> wrote:

> Also got rid of a conditional
>   in its code that was never false.
>

Please specify what this is; don't make me hunt through the nearly 100
lines of moved code to make me find the line (or lines) that changed.

thanks,
mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark P, 2014-06-06 18:07:41]

This is the last message I'll send before you tell me to look again.

--mark

https://codereview.chromium.org/312423003/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/autocomplete_provider.h (right):

https://codereview.chromium.org/312423003/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/autocomplete_provider.h:263: bool
return_input_on_failure);
This is awkward.  Why not use two outparams or return a pair? The way this
currently works make it impossible to determine simultaneously whether the
function call succeeded and its return value.  I solidly don't like it.

[Peter Kasting, 2014-06-06 18:29:08]

PTAL.

On 2014/06/06 18:06:59, Mark P wrote:
> On Thu, Jun 5, 2014 at 6:44 PM, Peter Kasting wrote:
> > Also got rid of a conditional in its code that was never false.
> 
> Please specify what this is; don't make me hunt through the nearly 100
> lines of moved code to make me find the line (or lines) that changed.

Sorry.  Updated CL description.

https://codereview.chromium.org/312423003/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/autocomplete_provider.h (right):

https://codereview.chromium.org/312423003/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/autocomplete_provider.h:263: bool
return_input_on_failure);
On 2014/06/06 18:07:41, Mark P wrote:
> This is awkward.  Why not use two outparams or return a pair? The way this
> currently works make it impossible to determine simultaneously whether the
> function call succeeded and its return value.  I solidly don't like it.

Switched to returning a pair.

[Mark P, 2014-06-06 18:51:22]

lgtm

[Peter Kasting, 2014-06-06 21:11:02]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-06-06 21:12:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/312423003/60001

[commit-bot: I haz the power, 2014-06-06 22:03:15]

Change committed as 275540