Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: media/filters/source_buffer_stream_unittest.cc

Issue 312403002: Fix crashes caused when SourceBuffer.remove() is called starting at the presentation duration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/source_buffer_stream_unittest.cc
diff --git a/media/filters/source_buffer_stream_unittest.cc b/media/filters/source_buffer_stream_unittest.cc
index 1cd9cfa3f67c2050b9c092e4f78d0ef5399f5e87..c653418a94573429ca118a5589acc94c9d3701e4 100644
--- a/media/filters/source_buffer_stream_unittest.cc
+++ b/media/filters/source_buffer_stream_unittest.cc
@@ -3535,6 +3535,17 @@ TEST_F(SourceBufferStreamTest,
CheckExpectedBuffers("90K 121 151");
}
+TEST_F(SourceBufferStreamTest, Remove_StartingAtDuration) {
+ Seek(0);
+ NewSegmentAppend("10K 40 70K 100 130K");
+ CheckExpectedRangesByTimestamp("{ [10,160) }");
+
+ RemoveInMs(160, 165, 160);
+
+ CheckExpectedRangesByTimestamp("{ [10,160) }");
+ CheckExpectedBuffers("10K 40 70K 100 130K");
+}
+
TEST_F(SourceBufferStreamTest, Text_Append_SingleRange) {
SetTextStream();
NewSegmentAppend("0K 500K 1000K");
« media/filters/source_buffer_stream.cc ('K') | « media/filters/source_buffer_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698