Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 312343002: - Fix truncation in Socket calls. (Closed)

Created:
6 years, 6 months ago by Ivan Posva
Modified:
6 years, 6 months ago
Reviewers:
Anders Johnsen, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)
Visibility:
Public.

Description

- Fix truncation in Socket calls. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M runtime/bin/socket.h View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/socket_android.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/socket_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/socket_macos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
6 years, 6 months ago (2014-06-05 17:27:14 UTC) #1
siva
lgtm
6 years, 6 months ago (2014-06-05 17:33:28 UTC) #2
Ivan Posva
Committed patchset #1 manually as r37037 (presubmit successful).
6 years, 6 months ago (2014-06-05 17:33:57 UTC) #3
Anders Johnsen
6 years, 6 months ago (2014-06-05 19:27:59 UTC) #4
Message was sent while issue was closed.
lgtm, thank you Ivan!

Powered by Google App Engine
This is Rietveld 408576698