chrome/browser/sync/profile_sync_service.cc - Issue 312333005: Make the "Tabs" item on about:sync non-yellow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 312333005: Make the "Tabs" item on about:sync non-yellow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added IsProxyType function and unit test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index b4ce8b1c1543127e992b9f823b2d8275c40db8df..d3b5eea1b99ea7b9e3dbb29cd7d078da353232d8 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -2005,6 +2005,11 @@ base::Value* ProfileSyncService::GetTypeStatusMap() const {

", " + error.message();

type_status->SetString("status", "error");

type_status->SetString("value", error_text);

+ } else if (syncer::IsProxyType(type) && passive_types.Has(type)) {

+ // Show a proxy type in "ok" state unless it is disabled by user.

+ DCHECK(!throttled_types.Has(type));

+ type_status->SetString("status", "ok");

+ type_status->SetString("value", "Passive");

} else if (throttled_types.Has(type) && passive_types.Has(type)) {

type_status->SetString("status", "warning");

type_status->SetString("value", "Passive, Throttled");