Make the "Tabs" item on about:sync non-yellow

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 59 matching lines @@
 #include "components/sync_driver/pref_names.h"
 #include "components/sync_driver/system_encryptor.h"
 #include "components/sync_driver/user_selectable_sync_type.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "grit/generated_resources.h"
 #include "net/cookies/cookie_monster.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "sync/api/sync_error.h"
+#include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/configure_reason.h"
 #include "sync/internal_api/public/http_bridge_network_resources.h"
 #include "sync/internal_api/public/network_resources.h"
 #include "sync/internal_api/public/sessions/type_debug_info_observer.h"
 #include "sync/internal_api/public/sync_core_proxy.h"
 #include "sync/internal_api/public/sync_encryption_handler.h"
 #include "sync/internal_api/public/util/experiments.h"
 #include "sync/internal_api/public/util/sync_string_conversions.h"
 #include "sync/js/js_event_details.h"
 #include "sync/util/cryptographer.h"
@@ skipping 1885 matching lines @@
       const syncer::SyncError &error = error_map.find(type)->second;
       DCHECK(error.IsSet());
       std::string error_text = "Error: " + error.location().ToString() +
           ", " + error.message();
       type_status->SetString("status", "error");
       type_status->SetString("value", error_text);
     } else if (throttled_types.Has(type) && passive_types.Has(type)) {
       type_status->SetString("status", "warning");
       type_status->SetString("value", "Passive, Throttled");
     } else if (passive_types.Has(type)) {
-      type_status->SetString("status", "warning");
+      // Set status to ok for a passive proxy type (which is always passive);

[rlarocque, 2014/06/05 21:21:11]

nit: I would rephrase this so that the check for proxy types is the in the outer
if statement, rather than making this a special case of the passive state.

I believe proxy types exist in only one of two states: enabled (== passive) or
disabled.  There's no point in letting them traverse through all these other if
branches.  Better to filter them out earlier.

[stanisc, 2014/06/06 01:15:44]

Done.

+      // otherwise treat that as a warning.
+      if (type >= syncer::FIRST_PROXY_TYPE && type <= syncer::LAST_PROXY_TYPE) {

[rlarocque, 2014/06/05 21:21:11]

Is there no IsProxyType() helper function in model_type.cc?  If not, there
probably should be.

[stanisc, 2014/06/06 01:15:44]

I searched for FIRST_PROXY_TYPE and LAST_PROXY_TYPE and didn't get any hits
except in one unit test. I'll add one.

[stanisc, 2014/06/06 01:15:44]

Done.

+        type_status->SetString("status", "ok");
+      } else {
+        type_status->SetString("status", "warning");
+      }
       type_status->SetString("value", "Passive");
     } else if (throttled_types.Has(type)) {
       type_status->SetString("status", "warning");
       type_status->SetString("value", "Throttled");
     } else if (GetRegisteredNonBlockingDataTypes().Has(type)) {
       type_status->SetString("status", "ok");
       type_status->SetString("value", "Non-Blocking");
     } else if (active_types.Has(type)) {
       type_status->SetString("status", "ok");
       type_status->SetString("value", "Active: " +
@@ skipping 472 matching lines @@
   network_resources_ = network_resources.Pass();
 }
 
 bool ProfileSyncService::HasSyncingBackend() const {
   return backend_mode_ != SYNC ? false : backend_ != NULL;
 }
 
 void ProfileSyncService::SetBackupStartDelayForTest(base::TimeDelta delay) {
   backup_start_delay_ = delay;
 }