Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: content/browser/renderer_host/input/touch_selection_controller.cc

Issue 312293002: Paste popup is positioning properly during content scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Unittest failure issues. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/touch_selection_controller.cc
diff --git a/content/browser/renderer_host/input/touch_selection_controller.cc b/content/browser/renderer_host/input/touch_selection_controller.cc
index 6fc01c275ef74a204e1e0f1a1535cc079b28d9ce..7a9da4226ceeb827c19557c34780ebbc2532e33e 100644
--- a/content/browser/renderer_host/input/touch_selection_controller.cc
+++ b/content/browser/renderer_host/input/touch_selection_controller.cc
@@ -86,7 +86,8 @@ void TouchSelectionController::OnSelectionBoundsChanged(
return;
}
- HideAndDisallowShowingAutomatically();
+ if (last_input_event_type_ != LONG_PRESS)
jdduke (slow) 2014/08/02 14:23:00 Did you change this? This looks wrong, and it's co
AKVT 2014/08/04 13:45:32 Corrected the condition to show the insertion hand
+ HideAndDisallowShowingAutomatically();
}
bool TouchSelectionController::WillHandleTouchEvent(
@@ -183,8 +184,10 @@ bool TouchSelectionController::Animate(base::TimeTicks frame_time) {
}
void TouchSelectionController::OnHandleDragBegin(const TouchHandle& handle) {
- if (&handle == insertion_handle_.get())
+ if (&handle == insertion_handle_.get()) {
+ client_->OnSelectionEvent(INSERTION_DRAG_STARTED, GetStartPosition());
return;
+ }
if (&handle == start_selection_handle_.get()) {
fixed_handle_position_ = end_selection_handle_->position() -

Powered by Google App Engine
This is Rietveld 408576698