Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java

Issue 312293002: Paste popup is positioning properly during content scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unittests for the newly added event. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java b/content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java
index 0745d207edb7da317513c811b2d5eafad3224367..220a04a93df808e7ea9d1291f1848225ab524570 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java
@@ -158,7 +158,13 @@ public class PastePopupMenu implements OnClickListener {
coords[0] = Math.min(screenWidth - width, coords[0]);
}
- mContainer.showAtLocation(mParent, Gravity.NO_GRAVITY, coords[0], coords[1]);
+ if (!isShowing()) {
+ // Popup is showing first time
jdduke (slow) 2014/08/01 15:10:51 Nit: No need for this comment, I think it's pretty
AKVT 2014/08/01 15:23:25 Done.
+ mContainer.showAtLocation(mParent, Gravity.NO_GRAVITY, coords[0], coords[1]);
+ } else {
+ // Repositioning already showing popup.
+ mContainer.update(coords[0], coords[1], -1, -1);
+ }
}
private int viewIndex(boolean onTop) {

Powered by Google App Engine
This is Rietveld 408576698