content/browser/renderer_host/input/touch_selection_controller.cc - Issue 312293002: Paste popup is positioning properly during content scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller.cc

Issue 312293002: Paste popup is positioning properly during content scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unittests for the newly added event. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/selection_event_type_list.h ('k') | content/browser/renderer_host/input/touch_selection_controller_unittest.cc » ('j') | content/browser/renderer_host/input/touch_selection_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller.cc b/content/browser/renderer_host/input/touch_selection_controller.cc

index 6fc01c275ef74a204e1e0f1a1535cc079b28d9ce..7a9da4226ceeb827c19557c34780ebbc2532e33e 100644

--- a/content/browser/renderer_host/input/touch_selection_controller.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller.cc

@@ -86,7 +86,8 @@ void TouchSelectionController::OnSelectionBoundsChanged(

return;

}

- HideAndDisallowShowingAutomatically();

+ if (last_input_event_type_ != LONG_PRESS)

+ HideAndDisallowShowingAutomatically();

}

bool TouchSelectionController::WillHandleTouchEvent(

@@ -183,8 +184,10 @@ bool TouchSelectionController::Animate(base::TimeTicks frame_time) {

}

void TouchSelectionController::OnHandleDragBegin(const TouchHandle& handle) {

- if (&handle == insertion_handle_.get())

+ if (&handle == insertion_handle_.get()) {

+ client_->OnSelectionEvent(INSERTION_DRAG_STARTED, GetStartPosition());

return;

+ }

if (&handle == start_selection_handle_.get()) {

fixed_handle_position_ = end_selection_handle_->position() -