Paste popup is positioning properly during content scroll.

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.content.ClipboardManager;
@@ skipping 274 matching lines @@
 
     // Only valid when focused on a text / password field.
     private ImeAdapter mImeAdapter;
     private ImeAdapter.AdapterInputConnectionFactory mAdapterInputConnectionFactory;
     private AdapterInputConnection mInputConnection;
     private InputMethodManagerWrapper mInputMethodManagerWrapper;
 
     // Lazily created paste popup menu, triggered either via long press in an
     // editable region or from tapping the insertion handle.
     private PastePopupMenu mPastePopupMenu;
+    private boolean mWasPastePopupShowingOnInsertionDragStart;
 
     private PopupTouchHandleDrawableDelegate mTouchHandleDelegate;
 
     private PositionObserver mPositionObserver;
 
     // Size of the viewport in physical pixels as set from onSizeChanged.
     private int mViewportWidthPix;
     private int mViewportHeightPix;
     private int mPhysicalBackingWidthPix;
     private int mPhysicalBackingHeightPix;
@@ skipping 1879 matching lines @@
             case SelectionEventType.SELECTION_CLEARED:
                 mHasSelection = false;
                 mUnselectAllOnActionModeDismiss = false;
                 hideSelectActionBar();
                 break;
 
             case SelectionEventType.INSERTION_SHOWN:
                 mHasInsertion = true;
                 break;
 
-            case SelectionEventType.INSERTION_MOVED:
-                // TODO(jdduke): Handle case where movement triggered by focus.
+            case SelectionEventType.INSERTION_DRAG_STARTED:
+                mWasPastePopupShowingOnInsertionDragStart = getPastePopup().isShowing();

[jdduke (slow), 2014/08/07 21:18:04]

getPastePopup() will create a new PastePopup if none exists. That's not really
necessary if we just want to find out of it's showing. Please change this and
the below query to:

mPastePopupMenu != null && mPastePopupMenu.isShowing();

[AKVT, 2014/08/08 12:54:44]

Done. Thanks

                 hidePastePopup();
                 break;
 
+            case SelectionEventType.INSERTION_MOVED:

[jdduke (slow), 2014/08/07 21:18:04]

if (mPastePopupMenu != null && mPastePopupMenu.isShowing() ...

[AKVT, 2014/08/08 12:54:44]

Done.

+                if (getPastePopup().isShowing() && !isScrollInProgress()) {
+                    showPastePopup((int) posXDip, (int) posYDip);
+                } else {
+                    hidePastePopup();
+                }
+                break;
+
             case SelectionEventType.INSERTION_TAPPED:
-                if (getPastePopup().isShowing())
+                if (mWasPastePopupShowingOnInsertionDragStart)
                     mPastePopupMenu.hide();

[jdduke (slow), 2014/08/07 21:18:04]

Let's make this |hidePastePopup()| to match the |showPastePopup()| call.

[AKVT, 2014/08/08 12:54:44]

Done.

                 else
                     showPastePopup((int) posXDip, (int) posYDip);
                 break;
 
             case SelectionEventType.INSERTION_CLEARED:
                 mHasInsertion = false;
+                mWasPastePopupShowingOnInsertionDragStart = false;
                 hidePastePopup();
                 break;
 
             default:
                 assert false : "Invalid selection event type.";
         }
     }
 
     public boolean getUseDesktopUserAgent() {
         if (mNativeContentViewCore != 0) {
@@ skipping 1083 matching lines @@
 
     private native void nativeExtractSmartClipData(long nativeContentViewCoreImpl,
             int x, int y, int w, int h);
     private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl, boolean opaque);
 
     private native void nativeResumeResponseDeferredAtStart(
             long nativeContentViewCoreImpl);
     private native void nativeSetHasPendingNavigationTransitionForTesting(
             long nativeContentViewCoreImpl);
 }