Paste popup is positioning properly during content scroll.

content/browser/renderer_host/input/touch_selection_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/touch_selection_controller.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/test/mock_motion_event.h"
 
 using ui::test::MockMotionEvent;
@@ skipping 73 matching lines @@
   void SetAnimationEnabled(bool enabled) { animation_enabled_ = enabled; }
   void SetDraggingEnabled(bool enabled) { dragging_enabled_ = enabled; }
 
   void ClearSelection() {
     controller_->OnSelectionBoundsChanged(gfx::RectF(),
                                           TOUCH_HANDLE_ORIENTATION_UNDEFINED,
                                           false,
                                           gfx::RectF(),
                                           TOUCH_HANDLE_ORIENTATION_UNDEFINED,
                                           false);
+    controller().HideAndDisallowShowingAutomatically();

[jdduke (slow), 2014/08/02 13:11:12]

This is not OK, you just completely changed the semantics of this call.

[AKVT, 2014/08/02 13:16:53]

Without this even after calling clearSelection() Event is expecting
SELECTION_SHOWN instead of SELECTION_CLEARED.

[jdduke (slow), 2014/08/02 14:23:00]

Which test? If a drag is in-progress the "clearing" will not take immediate
effect, this is by design.

[AKVT, 2014/08/04 13:45:32]

Corrected the source code to counter measure the change.

   }
 
   void ClearInsertion() { ClearSelection(); }
 
   void ChangeInsertion(const gfx::RectF& rect,
                        TouchHandleOrientation orientation,
                        bool visible) {
     controller_->OnSelectionBoundsChanged(
         rect, orientation, visible, rect, orientation, visible);
   }
@@ skipping 209 matching lines @@
 }
 
 TEST_F(TouchSelectionControllerTest, InsertionDragged) {
   base::TimeTicks event_time = base::TimeTicks::Now();
   controller().OnTapEvent();
   controller().OnSelectionEditable(true);
 
   // The touch sequence should not be handled if insertion is not active.
   MockMotionEvent event(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
   EXPECT_FALSE(controller().WillHandleTouchEvent(event));
+  EXPECT_EQ(SELECTION_CLEARED, GetLastEventType());

[jdduke (slow), 2014/08/02 13:11:12]

No need to check this it's just confusing.

[AKVT, 2014/08/04 13:45:32]

Done.

 
   float line_height = 10.f;
   gfx::RectF start_rect(10, 0, 0, line_height);
   bool visible = true;
   ChangeInsertion(start_rect, visible);
   EXPECT_EQ(INSERTION_SHOWN, GetLastEventType());
   EXPECT_EQ(start_rect.bottom_left(), GetLastEventAnchor());
 
   // The touch sequence should be handled only if the drawable reports a hit.
   EXPECT_FALSE(controller().WillHandleTouchEvent(event));
@@ skipping 34 matching lines @@
   controller().OnSelectionEditable(true);
   SetDraggingEnabled(true);
 
   gfx::RectF start_rect(10, 0, 0, 10);
   bool visible = true;
   ChangeInsertion(start_rect, visible);
   EXPECT_EQ(INSERTION_SHOWN, GetLastEventType());
 
   MockMotionEvent event(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
-  EXPECT_EQ(INSERTION_SHOWN, GetLastEventType());
+  //TODO(AKV): this test case has to be modified once crbug.com/394093 is fixed.
+  EXPECT_EQ(INSERTION_DRAG_STARTED, GetLastEventType());
 
   event = MockMotionEvent(MockMotionEvent::ACTION_UP, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   EXPECT_EQ(INSERTION_TAPPED, GetLastEventType());
 
   // Reset the insertion.
   ClearInsertion();
   controller().OnTapEvent();
   ChangeInsertion(start_rect, visible);
   ASSERT_EQ(INSERTION_SHOWN, GetLastEventType());
 
   // No tap should be signalled if the time between DOWN and UP was too long.
   event = MockMotionEvent(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   event = MockMotionEvent(MockMotionEvent::ACTION_UP,
                           event_time + base::TimeDelta::FromSeconds(1),
                           0,
                           0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
-  EXPECT_EQ(INSERTION_SHOWN, GetLastEventType());
+  EXPECT_EQ(INSERTION_DRAG_STARTED, GetLastEventType());
 
   // Reset the insertion.
   ClearInsertion();
   controller().OnTapEvent();
   ChangeInsertion(start_rect, visible);
   ASSERT_EQ(INSERTION_SHOWN, GetLastEventType());
 
   // No tap should be signalled if the touch sequence is cancelled.
   event = MockMotionEvent(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   event = MockMotionEvent(MockMotionEvent::ACTION_CANCEL, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
-  EXPECT_EQ(INSERTION_SHOWN, GetLastEventType());
+  EXPECT_EQ(INSERTION_DRAG_STARTED, GetLastEventType());
 }
 
 TEST_F(TouchSelectionControllerTest, SelectionBasic) {
   gfx::RectF start_rect(5, 5, 0, 10);
   gfx::RectF end_rect(50, 5, 0, 10);
   bool visible = true;
 
   // Selection events are ignored until automatic showing is enabled.
   ChangeSelection(start_rect, visible, end_rect, visible);
   EXPECT_EQ(gfx::PointF(), GetLastEventAnchor());
@@ skipping 154 matching lines @@
 
   visible = true;
   ChangeInsertion(insertion_rect, visible);
   EXPECT_FALSE(GetAndResetNeedsAnimate());
 
   controller().SetTemporarilyHidden(false);
   EXPECT_TRUE(GetAndResetNeedsAnimate());
 }
 
 }  // namespace content