Issue 312273002: fix two uninitialized reads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 312273002: fix two uninitialized reads (Closed)

Created:
6 years, 6 months ago by kcc2

Modified:
6 years, 6 months ago

Reviewers:
Bo Xu

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Visibility:
Public.

More Reviews

Description

fix two uninitialized reads https://code.google.com/p/pdfium/issues/detail?id=9 https://code.google.com/p/pdfium/issues/detail?id=10 BUG= R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/f0a5576

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	core/src/fxcodec/codec/fx_codec_jpeg.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	core/src/fxge/fx_freetype/fxft2.5.01/src/psaux/psconv.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kcc2

On 2014/06/05 16:44:35, bo_xu wrote: > lgtm I don't have commit access anyway, could someone ...

6 years, 6 months ago (2014-06-05 19:24:03 UTC) #2

kcc2

On 2014/06/05 16:44:35, bo_xu wrote: > lgtm I don't have commit access anyway, could someone ...

6 years, 6 months ago (2014-06-05 19:24:04 UTC) #3

jabdelmalek

6 years, 6 months ago (2014-06-05 19:29:24 UTC) #4

Message was sent while issue was closed.

On 2014/06/05 19:24:04, kcc2 wrote:
> On 2014/06/05 16:44:35, bo_xu wrote:
> > lgtm
> 
> I don't have commit access anyway, could someone please commit it for me?

yep I had landed it for you. i had added your name in the commit message locally
but apparently git cl land used the one from rietveld.

Expand Messages | Collapse Messages