Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 312253003: Add UseCounters for the types of mixed content we currently don't block. (Closed)

Created:
6 years, 6 months ago by Mike West
Modified:
6 years, 6 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Add UseCounters for the types of mixed content we currently don't block. In order to evaluate when we can start dropping support for passive mixed content, this patch adds counters to ResourceFetcher for the four resource types we currently don't block: images, media, tracks, and raw. This patch also drops the 'MixedContentFont' enum, as we now consider that active content. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +22 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Mind taking a look? -mike
6 years, 6 months ago (2014-06-05 06:54:31 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-05 07:01:05 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-05 07:24:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/312253003/1
6 years, 6 months ago (2014-06-05 07:25:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 08:34:24 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 11:26:50 UTC) #6
Message was sent while issue was closed.
Change committed as 175557

Powered by Google App Engine
This is Rietveld 408576698