Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 312253002: Test that a WebSocket handshake response with an empty valued header is accepted (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
yhirano
CC:
blink-reviews
Visibility:
Public.

Description

Test that a WebSocket handshake response with an empty valued header is accepted BUG=380075 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175770

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
A LayoutTests/http/tests/websocket/handshake-response-with-empty-valued-header.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/websocket/handshake-response-with-empty-valued-header-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/websocket/handshake-response-with-empty-valued-header_wsh.py View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-05 06:21:03 UTC) #1
yhirano
The expectation file is missing.
6 years, 6 months ago (2014-06-05 06:23:21 UTC) #2
tyoshino (SeeGerritForStatus)
On 2014/06/05 06:23:21, yhirano wrote: > The expectation file is missing. ooo, added
6 years, 6 months ago (2014-06-05 06:26:18 UTC) #3
yhirano
lgtm
6 years, 6 months ago (2014-06-05 06:51:50 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-05 07:04:37 UTC) #5
tyoshino (SeeGerritForStatus)
The CQ bit was unchecked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-05 07:04:47 UTC) #6
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-09 02:17:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/312253002/60001
6 years, 6 months ago (2014-06-09 02:18:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 03:20:59 UTC) #9
Message was sent while issue was closed. 
Change committed as 175770

Powered by Google App Engine
This is Rietveld 408576698