Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 312233003: Add fade eliding for Views Labels; related cleanup. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, ben+corewm_chromium.org, benquan, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, estade+watch_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org, Elliot Glaysher
Visibility:
Public.

Description

Add fade eliding for Views Labels; related cleanup. Support fade eliding behavior for Views Label[Button]. (needed for forthcoming LabelButton conversions, etc.) Remove unused head fading behavior, refine fade tail. (fades the end opposite the text's horizontal alignment) (centered fading uses content directionality alignment) (RenderText fades both ends of explicitly centered text) Consolidate gfx::ElideBehavior and Label::ElideBehavior. Nix Canvas::TruncateFadeMode and RenderText fade_[head|tail]. Add ELIDE_EMAIL and FADE_TAIL enum values, hide ElideEmail. Consolidate and rename Canvas::DrawFadedString functions. Refine Examples, cleanup enum and function uses. BUG=155363, 249938 TEST=No apparent eliding behavior changes or regressions. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275265

Patch Set 1 #

Patch Set 2 : Remove unused FADE_HEAD, simplify code. #

Patch Set 3 : Refine directionality, ellipsis, example. #

Patch Set 4 : Refine alignment check; minor additional cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -645 lines) Patch
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 3 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/elide_url.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas.h View 1 3 chunks +7 lines, -19 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 1 2 3 7 chunks +28 lines, -58 lines 0 comments Download
M ui/gfx/render_text.h View 1 4 chunks +5 lines, -16 lines 0 comments Download
M ui/gfx/render_text.cc View 1 2 10 chunks +19 lines, -34 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/text_constants.h View 1 2 2 chunks +20 lines, -20 lines 0 comments Download
M ui/gfx/text_elider.h View 3 chunks +5 lines, -33 lines 0 comments Download
M ui/gfx/text_elider.cc View 1 2 3 10 chunks +85 lines, -73 lines 0 comments Download
M ui/gfx/text_elider_unittest.cc View 1 9 chunks +22 lines, -26 lines 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.h View 3 chunks +4 lines, -14 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 3 5 chunks +29 lines, -39 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 38 chunks +52 lines, -83 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_aura_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/examples/label_example.cc View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M ui/views/examples/text_example.cc View 1 2 8 chunks +72 lines, -138 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 6 months ago (2014-06-05 18:43:13 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-05 20:47:18 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-05 21:00:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/312233003/60001
6 years, 6 months ago (2014-06-05 21:03:46 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 22:42:12 UTC) #5
Message was sent while issue was closed.
Change committed as 275265

Powered by Google App Engine
This is Rietveld 408576698