Pass chrome version and channel in CHLO message to server.

net/quic/crypto/crypto_protocol.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_CRYPTO_PROTOCOL_H_
 #define NET_QUIC_CRYPTO_CRYPTO_PROTOCOL_H_
 
 #include <string>
 
 #include "net/base/net_export.h"
@@ skipping 75 matching lines @@
 const QuicTag kPUBS = TAG('P', 'U', 'B', 'S');  // Public key values
 const QuicTag kSCID = TAG('S', 'C', 'I', 'D');  // Server config id
 const QuicTag kORBT = TAG('O', 'B', 'I', 'T');  // Server orbit.
 const QuicTag kPDMD = TAG('P', 'D', 'M', 'D');  // Proof demand.
 const QuicTag kPROF = TAG('P', 'R', 'O', 'F');  // Proof (signature).
 const QuicTag kCCS  = TAG('C', 'C', 'S', 0);    // Common certificate set
 const QuicTag kCCRT = TAG('C', 'C', 'R', 'T');  // Cached certificate
 const QuicTag kEXPY = TAG('E', 'X', 'P', 'Y');  // Expiry
 const QuicTag kIFCW = TAG('I', 'F', 'C', 'W');  // Initial flow control receive
                                                 // window.
+const QuicTag kCVER = TAG('C', 'V', 'E', 'R');  // Client Version.

[Ryan Hamilton, 2014/06/04 22:31:15]

Heh, we used to have a CVER tag in an earlier version of the version negotiation
spec :>

That being said, I'm not in love with "VER" as part of this tag name, but I'm
not really sure why. I wonder if we should have something like Client
Description (CDSC) because it's more of a description than a version, or it will
be once more than one browser supports QUIC. You could almost use User Agent
(UA) though that might suggest that the *full* UA string, which we don't want.

Anyway, minor point. 

[jar (doing other things), 2014/06/05 02:16:23]

As a matter of course... for these "less important" items, and most critically,
for items that don't vary from CHLO to CHLO, it is nice to have alphabetically
large initial letters, to best ensure the tags will be late in the tag listing.

Perhaps a nice unification (avoding a previously used tag??) would be:

User Agent Chrome Version
UACV

Other suggestions?  
YMMV (which is not a suggestion ;-) )

[ramant (doing other things), 2014/06/05 02:51:55]

Used kCDSC.
Done.

[ramant (doing other things), 2014/06/05 02:51:55]

Changed CDSC to UACV
Done.

+
 
 // Server hello tags
 const QuicTag kCADR = TAG('C', 'A', 'D', 'R');  // Client IP address and port
 
 // CETV tags
 const QuicTag kCIDK = TAG('C', 'I', 'D', 'K');  // ChannelID key
 const QuicTag kCIDS = TAG('C', 'I', 'D', 'S');  // ChannelID signature
 
 // Public reset tags
 const QuicTag kRNON = TAG('R', 'N', 'O', 'N');  // Public reset nonce proof
@@ skipping 41 matching lines @@
 // amplification factor of any mirror DoS attack.
 //
 // A client may pad an inchoate client hello to a size larger than
 // kClientHelloMinimumSize to make it more likely to receive a complete
 // rejection message.
 const size_t kClientHelloMinimumSize = 1024;
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_CRYPTO_PROTOCOL_H_