Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 312193004: Don't force full repaint on size change in style (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index 9ca93e6cb026aae6ef61fc27d699913bdaea63a5..ed1a847e9800066e23378472cf1d997da19c9b38 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -1748,7 +1748,7 @@ bool RenderObject::repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repa
repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds.x(), newBounds.maxY(), oldBounds.width(), -deltaBottom), invalidationReason);
// FIXME: This is a limitation of our visual overflow being a single rectangle.
- if (!style()->boxShadow() && !style()->hasBorderImageOutsets() && !style()->hasOutline())
+ if (!style()->hasBorder() && !style()->boxShadow() && !style()->hasBorderImageOutsets() && !style()->hasOutline())
Julien - ping for review 2014/06/11 17:53:24 The border does not generate visual overflow and i
Xianzhu 2014/06/16 16:25:29 For example, when an object with border is increas
Julien - ping for review 2014/06/16 20:04:24 OK, I really think we should include the border in
Xianzhu 2014/06/16 20:49:16 I had tried to modify regular invalidation code, b
return false;
// We didn't move, but we did change size. Invalidate the delta, which will consist of possibly
« no previous file with comments | « LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt ('k') | Source/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698