[Sync] Add support for dynamically enabling/disabling types

chrome/browser/sync/glue/sync_backend_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/sync_backend_host_impl.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 329 matching lines @@
   // until they succeed or the backend is shut down.
 
   syncer::ModelTypeSet previous_types = registrar_->GetLastConfiguredTypes();
 
   syncer::ModelTypeSet disabled_types =
       GetDataTypesInState(DISABLED, config_state_map);
   syncer::ModelTypeSet fatal_types =
       GetDataTypesInState(FATAL, config_state_map);
   syncer::ModelTypeSet crypto_types =
       GetDataTypesInState(CRYPTO, config_state_map);
+  syncer::ModelTypeSet unready_types =
+      GetDataTypesInState(UNREADY, config_state_map);
   disabled_types.PutAll(fatal_types);
   disabled_types.PutAll(crypto_types);
+  disabled_types.PutAll(unready_types);

[haitaol1, 2014/06/19 18:14:35]

This will remove routing info of unready types in registar. If unready type is
disabled later, it seems the the type won't be added to types_to_purge below
because types_to_purge is calculated by differing previous and current types in
routing info. Actually I wonder if there's a bug with crypto_types because of
this.

[Nicolas Zea, 2014/06/19 21:13:02]

Hmm, I suspect you're right. They'll both be purged on the next restart though,
as part of the first configuration, so it's not too problematic. That said, I'll
file a bug to fix that separately, since it's an existing issue and would
probably require some further logic.

Added todo.

   syncer::ModelTypeSet active_types =
       GetDataTypesInState(CONFIGURE_ACTIVE, config_state_map);
   syncer::ModelTypeSet clean_first_types =
       GetDataTypesInState(CONFIGURE_CLEAN, config_state_map);
   syncer::ModelTypeSet types_to_download = registrar_->ConfigureDataTypes(
       syncer::Union(active_types, clean_first_types),
       disabled_types);
   types_to_download.PutAll(clean_first_types);
   types_to_download.RemoveAll(syncer::ProxyTypes());
   if (!types_to_download.Empty())
@@ skipping 23 matching lines @@
 
   syncer::ModelSafeRoutingInfo routing_info;
   registrar_->GetModelSafeRoutingInfo(&routing_info);
 
   syncer::ModelTypeSet current_types = registrar_->GetLastConfiguredTypes();
   syncer::ModelTypeSet types_to_purge =
       syncer::Difference(previous_types, current_types);
   syncer::ModelTypeSet inactive_types =
       GetDataTypesInState(CONFIGURE_INACTIVE, config_state_map);
   types_to_purge.RemoveAll(inactive_types);
+  types_to_purge.RemoveAll(unready_types);
 
   // If a type has already been disabled and unapplied or journaled, it will
   // not be part of the |types_to_purge| set, and therefore does not need
   // to be acted on again.
   fatal_types.RetainAll(types_to_purge);
   syncer::ModelTypeSet unapply_types =
       syncer::Union(crypto_types, clean_first_types);
   unapply_types.RetainAll(types_to_purge);
 
   DCHECK(syncer::Intersection(current_types, fatal_types).Empty());
@@ skipping 462 matching lines @@
 
 base::MessageLoop* SyncBackendHostImpl::GetSyncLoopForTesting() {
   return registrar_->sync_thread()->message_loop();
 }
 
 }  // namespace browser_sync
 
 #undef SDVLOG
 
 #undef SLOG