Chromium Code Reviews Chromium Code Reviews
Issue 312143003:
This fixes bug with trying to get properties of non-object (symbol). (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <script src="../../http/tests/inspector/inspector-test.js"></script> | 3 <script src="../../http/tests/inspector/inspector-test.js"></script> |
| 4 <script src="../../http/tests/inspector/console-test.js"></script> | 4 <script src="../../http/tests/inspector/console-test.js"></script> |
| 5 <script> | 5 <script> |
| 6 | 6 |
| 7 function onload() | 7 function onload() |
| 8 { | 8 { |
| 9 var obj = new Object(); | 9 var obj = new Object(); |
| 10 obj["a"] = 1; | 10 obj["a"] = 1; |
| 11 obj[Symbol()] = 2; | 11 obj[Symbol()] = 2; |
| 12 obj[Symbol("a")] = 3; | 12 obj[Symbol("a")] = 3; |
| 13 obj[Symbol("a")] = Symbol.iterator; | 13 obj[Symbol("a")] = Symbol.iterator; |
| 14 obj[Symbol.iterator] = Symbol("foo"); | 14 obj[Symbol.iterator] = Symbol("foo"); |
| 15 console.dir(obj); | 15 console.dir(obj); |
| 16 | 16 |
| 17 // This used to crash in debug build. | |
| 18 console.dir(Symbol()); | |
| 19 // This should correctly display information about the function. | |
| 20 console.dir(function() {}); | |
|
aandrey
2014/06/05 15:13:23
this has nothing to do with es6.
plz move to inspe
Alexandra Mikhaylova
2014/06/06 09:49:51
Done.
| |
| 21 | |
| 17 runTest(); | 22 runTest(); |
| 18 } | 23 } |
| 19 | 24 |
| 20 function test() | 25 function test() |
| 21 { | 26 { |
| 22 InspectorTest.expandConsoleMessages(dumpConsoleMessages); | 27 InspectorTest.expandConsoleMessages(dumpConsoleMessages); |
| 23 | 28 |
| 24 function dumpConsoleMessages() | 29 function dumpConsoleMessages() |
| 25 { | 30 { |
| 26 InspectorTest.dumpConsoleMessages(false, false, InspectorTest.textConten tWithLineBreaks); | 31 InspectorTest.dumpConsoleMessages(false, false, InspectorTest.textConten tWithLineBreaks); |
| 27 InspectorTest.completeTest(); | 32 InspectorTest.completeTest(); |
| 28 } | 33 } |
| 29 } | 34 } |
| 30 | 35 |
| 31 </script> | 36 </script> |
| 32 </head> | 37 </head> |
| 33 | 38 |
| 34 <body onload="onload()"> | 39 <body onload="onload()"> |
| 35 <p> | 40 <p> |
| 36 Tests that console logging dumps proper messages. | 41 Tests that console logging dumps proper messages. |
| 37 </p> | 42 </p> |
| 38 | 43 |
| 39 </body> | 44 </body> |
| 40 </html> | 45 </html> |
| OLD | NEW |
