Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 312143002: Fix build with system harfbuzz (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build with system harfbuzz This is upstreaming Gentoo Linux patch BUG=none R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/linux/unbundle/harfbuzz.gyp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-04 12:25:21 UTC) #1
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-04 17:45:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/312143002/1
6 years, 6 months ago (2014-06-04 17:46:27 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 21:20:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 21:28:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13388)
6 years, 6 months ago (2014-06-04 21:28:26 UTC) #6
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-05 14:25:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r275094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698