Minor cleanups to flakytests.py

Minor cleanups to flakytests.py

-Pass -f instead of setting EDITOR.
-Put a message at the top of FlakyTests saying it's autogenerated.
-Add a test that goes through the upload codepath.
-Have ExecutiveMock log calls to run_and_throw_if_fail.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175821

[Dirk Pranke, 2014-06-09 17:07:10]

lgtm

https://codereview.chromium.org/312103005/diff/40001/Tools/Scripts/webkitpy/t...
File Tools/Scripts/webkitpy/tool/commands/flakytests.py (right):

https://codereview.chromium.org/312103005/diff/40001/Tools/Scripts/webkitpy/t...
Tools/Scripts/webkitpy/tool/commands/flakytests.py:114:
fs.write_text_file(flaky_tests_path, """# This file is generated by webkit-patch
update-flaky-tests from the flakiness dashboard data.
Nit: I think you can do 

fs.write_text_file(flaky_tests_path(, """\
# This file is generated ...
""")

to make things a little easier to read.

Though, in this case, I might just use indented strings that are
auto-concatenated, e.g.:

fs.write_text_file(flaky_tests_path,
                          "# this file is generated ...\n"
                          "# Manual changes will be overwritten.\n"
                          "\n"
                          "%s" % ...)

to preserve the indentation.

[ojan, 2014-06-09 20:07:12]

I moved the multiline strings to constants at the top and used auto-concated
single-line-strings. I agree it's more readable. I'm going to assume the lgtm
still applies, but if you take a look and don't like something, I'm happy to fix
in a followup.

[commit-bot: I haz the power, 2014-06-09 20:07:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/312103005/60001

[commit-bot: I haz the power, 2014-06-09 21:12:01]

Change committed as 175821