Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 312103004: Content Shell test_runner hooks for <audio> and <video> blocking. (Closed)

Created:
6 years, 6 months ago by pwnall-personal
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Content Shell test_runner hooks for <audio> and <video> blocking. These hooks are necessary for the LayoutTests in the blink-side CL referenced below, which adds the ability to block <audio> and <video> media. The blocking works similarly to the currently implemented ability to block images. https://codereview.chromium.org/27694002/ BUG=50132 TEST=LayoutTests in the blink CL pass with this CL patched in Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M content/shell/renderer/test_runner/WebPermissions.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/WebPermissions.cpp View 3 chunks +14 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pwnall-personal
Can you please take a look? I have a blink-side CL depending on this, and ...
6 years, 6 months ago (2014-06-08 21:25:58 UTC) #1
Dirk Pranke
seems fine. lgtm.
6 years, 6 months ago (2014-06-09 17:19:09 UTC) #2
pwnall-personal
The CQ bit was checked by costan@gmail.com
6 years, 6 months ago (2014-06-09 17:55:18 UTC) #3
pwnall-personal
On 2014/06/09 17:19:09, Dirk Pranke wrote: > seems fine. > > lgtm. Thank you for ...
6 years, 6 months ago (2014-06-09 17:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/312103004/1
6 years, 6 months ago (2014-06-09 17:56:57 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 11:10:41 UTC) #6
Message was sent while issue was closed.
Change committed as 275984

Powered by Google App Engine
This is Rietveld 408576698