Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 312093007: Revert of Added BookmarkClient::CanBeEditedByUser. (Closed)

Created:
6 years, 6 months ago by Kibeom Kim (inactive)
Modified:
6 years, 6 months ago
Reviewers:
Joao da Silva, sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert of Added BookmarkClient::CanBeEditedByUser. (https://codereview.chromium.org/317333004/) Reason for revert: http://crbug.com/381921 Original issue's description: > Added BookmarkClient::CanBeEditedByUser. > > CanBeEditedByUser indicates if a bookmark can be edited by the user or not. > All of the bookmarks in the bookmark_bar_node, the other_node and the > mobile_node are always editable but some of the extra nodes provided by the > client may be unmodifiable. > > Also updated other methods to work only with user-editable nodes, and added > utility helpers to detect nodes that can or can't be edited. > > BUG=49598 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275523 TBR=sky@chromium.org,joaodasilva@chromium.org NOTREECHECKS=true NOTRY=true BUG=49598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -261 lines) Patch
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_client.h View 1 chunk +8 lines, -7 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 2 chunks +6 lines, -7 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 13 chunks +13 lines, -84 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.h View 4 chunks +4 lines, -14 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 7 chunks +11 lines, -30 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 4 chunks +3 lines, -67 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kibeom Kim (inactive)
Created Revert of Added BookmarkClient::CanBeEditedByUser.
6 years, 6 months ago (2014-06-06 22:27:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/312093007/1
6 years, 6 months ago (2014-06-06 22:28:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 22:28:50 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 22:28:51 UTC) #4
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698