Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 312093005: IndexedDB: Sprinkle DISALLOW_COPY_AND_ASSIGN where appropriate (Closed)

Created:
6 years, 6 months ago by jsbell
Modified:
6 years, 6 months ago
Reviewers:
ericu, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

IndexedDB: Sprinkle DISALLOW_COPY_AND_ASSIGN where appropriate Much of the Indexed DB backend was ported from blink, and we didn't remember to add these macros in most places. Toss 'em in where easy. BUG=381456 R=cmumford@chromium.org,ericu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275653

Patch Set 1 #

Patch Set 2 : Whitespace fixes #

Total comments: 2

Patch Set 3 : Add missing private: #

Patch Set 4 : Add missing private: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -1 line) Patch
M content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.h View 4 chunks +7 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 9 chunks +18 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 5 chunks +12 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 5 chunks +15 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc View 4 chunks +9 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_connection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_error.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 6 chunks +13 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_index_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_coordinator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_transaction.h View 4 chunks +8 lines, -0 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 2 4 chunks +9 lines, -0 lines 0 comments Download
M content/child/indexed_db/indexed_db_key_builders.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jsbell
cmumford@, ericu@ - PTAL? Found via: git grep '^\s*class[^;]+$|DISALLOW' *.{h,cc} ... and looking for missing ...
6 years, 6 months ago (2014-06-06 21:40:29 UTC) #1
cmumford
https://codereview.chromium.org/312093005/diff/20001/content/child/indexed_db/indexed_db_dispatcher_unittest.cc File content/child/indexed_db/indexed_db_dispatcher_unittest.cc (right): https://codereview.chromium.org/312093005/diff/20001/content/child/indexed_db/indexed_db_dispatcher_unittest.cc#newcode55 content/child/indexed_db/indexed_db_dispatcher_unittest.cc:55: DISALLOW_COPY_AND_ASSIGN(MockDispatcher); Do you want a private before this?
6 years, 6 months ago (2014-06-06 22:10:42 UTC) #2
jsbell
https://codereview.chromium.org/312093005/diff/20001/content/child/indexed_db/indexed_db_dispatcher_unittest.cc File content/child/indexed_db/indexed_db_dispatcher_unittest.cc (right): https://codereview.chromium.org/312093005/diff/20001/content/child/indexed_db/indexed_db_dispatcher_unittest.cc#newcode55 content/child/indexed_db/indexed_db_dispatcher_unittest.cc:55: DISALLOW_COPY_AND_ASSIGN(MockDispatcher); On 2014/06/06 22:10:42, cmumford wrote: > Do you ...
6 years, 6 months ago (2014-06-06 22:18:14 UTC) #3
cmumford
lgtm
6 years, 6 months ago (2014-06-06 22:20:07 UTC) #4
jsbell
ericu@ - can I get your committer stamp?
6 years, 6 months ago (2014-06-06 22:33:34 UTC) #5
ericu
*STAMP* LGTM
6 years, 6 months ago (2014-06-06 23:38:51 UTC) #6
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-06 23:39:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/312093005/60001
6 years, 6 months ago (2014-06-06 23:40:37 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 02:35:46 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:46:37 UTC) #10
Message was sent while issue was closed. 
Change committed as 275653

Powered by Google App Engine
This is Rietveld 408576698