Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 312093003: Typo fix (Closed)

Created:
6 years, 6 months ago by ericu
Modified:
6 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Typo fix; since both instances of the parameter were typoed, this actually did what we wanted it to, because of C++'s variable name shadowing rules. But it looked really bad. BUG=381791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ericu
6 years, 6 months ago (2014-06-06 18:54:07 UTC) #1
jsbell
lgtm You may want to mention why it worked before in the commit comment, so ...
6 years, 6 months ago (2014-06-06 18:56:46 UTC) #2
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 6 months ago (2014-06-06 20:11:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/312093003/1
6 years, 6 months ago (2014-06-06 20:15:58 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:55:56 UTC) #5
Message was sent while issue was closed.
Change committed as 275605

Powered by Google App Engine
This is Rietveld 408576698