Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 312073002: Oilpan: Replace RefPtrs to Node and its subclasses in core/testing with Oilpan transition types. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Replace RefPtrs to Node and its subclasses in core/testing with Oilpan transition types. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/testing/LayerRect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/LayerRectList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/LayerRectList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-04 05:32:22 UTC) #1
tkent
Please review this
6 years, 6 months ago (2014-06-04 05:33:10 UTC) #2
haraken
LGTM
6 years, 6 months ago (2014-06-04 05:42:34 UTC) #3
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-04 06:26:59 UTC) #4
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-04 06:28:12 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-04 07:21:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/312073002/1
6 years, 6 months ago (2014-06-04 07:22:15 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 08:13:17 UTC) #8
Message was sent while issue was closed.
Change committed as 175453

Powered by Google App Engine
This is Rietveld 408576698