Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 31203002: Add UseCounters for prefixed HTMLVideoElement APIs (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add UseCounters for prefixed HTMLVideoElement APIs Count the *Fullscreen and *FullScreen calls separately, since it's likely that the later are less common and could potentially be dropped first. BUG=309364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M Source/core/html/HTMLVideoElement.h View 2 chunks +7 lines, -4 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 4 chunks +11 lines, -2 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
The second half of bug 309364, let's hope some of these counts are really low ...
7 years, 2 months ago (2013-10-20 20:16:37 UTC) #1
eseidel
WAT? We support both WebKitFullscreen and WebKitFullScreen?
7 years, 2 months ago (2013-10-20 20:58:15 UTC) #2
philipj_slow
On 2013/10/20 20:58:15, eseidel wrote: > WAT? We support both WebKitFullscreen and WebKitFullScreen? Yes, is ...
7 years, 2 months ago (2013-10-20 21:12:11 UTC) #3
eseidel
lgtm
7 years, 2 months ago (2013-10-20 21:16:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/31203002/1
7 years, 2 months ago (2013-10-20 21:16:14 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-20 22:41:58 UTC) #6
Message was sent while issue was closed.
Change committed as 160031

Powered by Google App Engine
This is Rietveld 408576698