Port net/tools/balsa to non-Linux platforms.

net/tools/balsa/balsa_frame.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/balsa/balsa_frame.h"
 
 #include <assert.h>
 #if __SSE2__
 #include <emmintrin.h>
 #endif  // __SSE2__
-#include <strings.h>
 
 #include <limits>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/port.h"
 #include "base/strings/string_piece.h"
 #include "net/tools/balsa/balsa_enums.h"
 #include "net/tools/balsa/balsa_headers.h"
 #include "net/tools/balsa/balsa_visitor_interface.h"
 #include "net/tools/balsa/buffer_interface.h"
 #include "net/tools/balsa/simple_buffer.h"
 #include "net/tools/balsa/split.h"
 #include "net/tools/balsa/string_piece_utils.h"
 
+#if defined(COMPILER_MSVC)
+#include <string.h>
+#define strncasecmp _strnicmp
+#else
+#include <strings.h>
+#endif
+
 namespace net {
 
 // Constants holding some header names for headers which can affect the way the
 // HTTP message is framed, and so must be processed specially:
 static const char kContentLength[] = "content-length";
 static const size_t kContentLengthSize = sizeof(kContentLength) - 1;
 static const char kTransferEncoding[] = "transfer-encoding";
 static const size_t kTransferEncodingSize = sizeof(kTransferEncoding) - 1;
 
 BalsaFrame::BalsaFrame()
@@ skipping 380 matching lines @@
                           &last_error_)) {
     parse_state_ = BalsaFrameEnums::PARSE_ERROR;
     visitor_->HandleHeaderError(this);
     return;
   }
   if (previous_error != last_error_) {
     visitor_->HandleHeaderWarning(this);
   }
 
   if (is_request_) {
-    int version_length =
+    size_t version_length =
         headers_->whitespace_4_idx_ - headers_->non_whitespace_3_idx_;
     visitor_->ProcessRequestFirstLine(
         begin + headers_->non_whitespace_1_idx_,
         headers_->whitespace_4_idx_ - headers_->non_whitespace_1_idx_,
         begin + headers_->non_whitespace_1_idx_,
         headers_->whitespace_2_idx_ - headers_->non_whitespace_1_idx_,
         begin + headers_->non_whitespace_2_idx_,
         headers_->whitespace_3_idx_ - headers_->non_whitespace_2_idx_,
         begin + headers_->non_whitespace_3_idx_,
         version_length);
@@ skipping 129 matching lines @@
     while (current < header_lines_end_m16) {
       __m128i header_bytes =
         _mm_loadu_si128(reinterpret_cast<const __m128i *>(current));
       __m128i colon_cmp =
         _mm_cmpeq_epi8(header_bytes, reinterpret_cast<__m128i>(colons));
       int colon_msk = _mm_movemask_epi8(colon_cmp);
       if (colon_msk == 0) {
         current += 16;
         continue;
       }
       current += (ffs(colon_msk) - 1);

[Nico, 2014/07/04 00:27:31]

I believe ffs() is only available if strings.h was included. clang/win sets
__SSE2__ but there's no strings.h header on Windows, so it can't find ffs().

Taking a step back, what is this tool for? Is it performance-sensitive? If not,
could this block (and a similar one below) just go away?

[wtc, 2014/07/07 16:50:16]

Chromium uses the code in net/tools/balsa only in some (non-performance) tests.
So it is not necessary for Chromium to compile this code with the best
performance. Also, if everything goes well, we should be able to replace this
code with something else within two or three weeks.

However, if it's not hard to port this code to Windows, I can take a stab at it.
So I'd be interested in learning about the Windows equivalent of ffs(). Is it
the _BitScanForward() function?

       if (current > line_end) {
         break;
       }
       goto found_colon;
     }
 #endif  // __SSE2__
     for (; current < line_end; ++current) {
       if (*current != ':') {
         continue;
       }
@@ skipping 959 matching lines @@
     << BalsaFrameEnums::ParseStateToString(parse_state_)
     << "$$$$$$$$$$$$$$$"
     << " consumed: " << (current - input);
   if (Error()) {
     LOG(INFO) << BalsaFrameEnums::ErrorCodeToString(ErrorCode());
   }
 #endif  // DEBUGFRAMER
   return current - input;
 }
 
-const uint32 BalsaFrame::kValidTerm1;
-const uint32 BalsaFrame::kValidTerm1Mask;
-const uint32 BalsaFrame::kValidTerm2;
-const uint32 BalsaFrame::kValidTerm2Mask;
-
 }  // namespace net