runtime/vm/intermediate_language_ia32.cc - Issue 311993007: VM: Reduce the number of edge counters in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 311993007: VM: Reduce the number of edge counters in generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: added other platforms Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 37078)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -8,6 +8,7 @@

#include "vm/intermediate_language.h"

#include "vm/dart_entry.h"

+#include "vm/flow_graph.h"

#include "vm/flow_graph_compiler.h"

#include "vm/locations.h"

#include "vm/object_store.h"

@@ -5998,7 +5999,9 @@

void TargetEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ Bind(compiler->GetJumpLabel(this));

if (!compiler->is_optimizing()) {

- if (FLAG_emit_edge_counters) {

+ if (FLAG_emit_edge_counters &&

+ (!last_instruction()->IsGoto() ||

+ (this == compiler->flow_graph().graph_entry()->normal_entry()))) {

srdjan 2014/06/06 14:59:51 How about factoring this test into TargetInstr::Ne

Florian Schneider 2014/06/10 08:56:39 Moved to FlowGraphCompiler::NeedEdgeCounter(Target

compiler->EmitEdgeCounter();

}

// The deoptimization descriptor points after the edge counter code for

« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | runtime/vm/intermediate_language_mips.cc » ('J')