VM: Reduce the number of edge counters in generated code.

runtime/vm/intermediate_language_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_MIPS.
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
+#include "vm/flow_graph.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/simulator.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 
 #define __ compiler->assembler()->
@@ skipping 4470 matching lines @@
 void GraphEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   if (!compiler->CanFallThroughTo(normal_entry())) {
     __ b(compiler->GetJumpLabel(normal_entry()));
   }
 }
 
 
 void TargetEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   __ Bind(compiler->GetJumpLabel(this));
   if (!compiler->is_optimizing()) {
-    if (FLAG_emit_edge_counters) {
+    if (FLAG_emit_edge_counters &&
+        (!last_instruction()->IsGoto() ||

[Cutch, 2014/06/06 14:56:12]

Maybe add a comment here:

// Emit an edge counter when the block does not end in a GoTo or
// when this is not an exception catch block entry into the graph.
bool should_emit_edge_counter = !last_instruction()->IsGoto() ||
    (this == compiler->flow_graph().graph_entry()->normal_entry());

if (FLAG_emit_edge_counters && should_emit_edge_counter) {
...

[Florian Schneider, 2014/06/10 08:56:39]

Done.

+         (this == compiler->flow_graph().graph_entry()->normal_entry()))) {
       compiler->EmitEdgeCounter();
     }
     // On MIPS the deoptimization descriptor points after the edge counter
     // code so that we can reuse the same pattern matching code as at call
     // sites, which matches backwards from the end of the pattern.
     compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
                                    deopt_id_,
                                    Scanner::kNoSourcePos);
   }
   if (HasParallelMove()) {
@@ skipping 166 matching lines @@
   compiler->GenerateCall(token_pos(),
                          &label,
                          PcDescriptors::kOther,
                          locs());
   __ Drop(ArgumentCount());  // Discard arguments.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS