Source/modules/websockets/MainThreadWebSocketChannel.cpp - Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/MainThreadWebSocketChannel.cpp

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/websockets/MainThreadWebSocketChannel.h ('k') | Source/modules/websockets/NewWebSocketChannelImpl.cpp » ('j') | Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/MainThreadWebSocketChannel.cpp

diff --git a/Source/modules/websockets/MainThreadWebSocketChannel.cpp b/Source/modules/websockets/MainThreadWebSocketChannel.cpp

index 5867f28ba226e620b9617d5cedd043983be501d2..95dc5ff44ea54742a00982bd8fac9710e7b449b8 100644

--- a/Source/modules/websockets/MainThreadWebSocketChannel.cpp

+++ b/Source/modules/websockets/MainThreadWebSocketChannel.cpp

@@ -355,10 +355,16 @@ void MainThreadWebSocketChannel::didReceiveSocketStreamData(SocketStreamHandle*

processBuffer();

}

-void MainThreadWebSocketChannel::didUpdateBufferedAmount(SocketStreamHandle*, size_t bufferedAmount)

+void MainThreadWebSocketChannel::didIncreaseBufferedAmount(SocketStreamHandle*, size_t amount)

{

if (m_client)

- m_client->didUpdateBufferedAmount(bufferedAmount);

+ m_client->didIncreaseBufferedAmount(amount);

+void MainThreadWebSocketChannel::didDecreaseBufferedAmount(SocketStreamHandle*, size_t amount)

+ if (m_client)

+ m_client->didDecreaseBufferedAmount(amount);

}

void MainThreadWebSocketChannel::didFailSocketStream(SocketStreamHandle* handle, const SocketStreamError& error)