Source/modules/websockets/NewWebSocketChannelImpl.h - Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/NewWebSocketChannelImpl.h

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/websockets/MainThreadWebSocketChannel.cpp ('K') | « Source/modules/websockets/MainThreadWebSocketChannel.cpp ('k') | Source/modules/websockets/NewWebSocketChannelImpl.cpp » ('j') | Source/modules/websockets/WebSocket.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/NewWebSocketChannelImpl.h

diff --git a/Source/modules/websockets/NewWebSocketChannelImpl.h b/Source/modules/websockets/NewWebSocketChannelImpl.h

index 12a91feeb60ca1bd32ed9d04b16b3b99a50da522..b6e4a6794ad63e48ffda392fc0e0c77f26fce20c 100644

--- a/Source/modules/websockets/NewWebSocketChannelImpl.h

+++ b/Source/modules/websockets/NewWebSocketChannelImpl.h

@@ -84,7 +84,6 @@ public:

virtual WebSocketChannel::SendResult send(const ArrayBuffer&, unsigned byteOffset, unsigned byteLength) OVERRIDE;

virtual WebSocketChannel::SendResult send(PassRefPtr<BlobDataHandle>) OVERRIDE;

virtual WebSocketChannel::SendResult send(PassOwnPtr<Vector<char> > data) OVERRIDE;

- virtual unsigned long bufferedAmount() const OVERRIDE;

// Start closing handshake. Use the CloseEventCodeNotSpecified for the code

// argument to omit payload.

virtual void close(int code, const String& reason) OVERRIDE;

@@ -168,7 +167,6 @@ private:

bool m_receivingMessageTypeIsText;

int64_t m_sendingQuota;

int64_t m_receivedDataSizeForFlowControl;

- unsigned long m_bufferedAmount;

size_t m_sentSizeOfTopMessage;

String m_subprotocol;

String m_extensions;