Source/web/WebSocketImpl.h - Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/WebSocketImpl.h

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/websockets/WebSocketChannelClient.h ('K') | « Source/platform/network/SocketStreamHandleClient.h ('k') | Source/web/WebSocketImpl.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 virtual unsigned long bufferedAmount() const OVERRIDE;	64 virtual unsigned long bufferedAmount() const OVERRIDE;

65 virtual void close(int code, const WebString& reason) OVERRIDE;	65 virtual void close(int code, const WebString& reason) OVERRIDE;

66 virtual void fail(const WebString& reason) OVERRIDE;	66 virtual void fail(const WebString& reason) OVERRIDE;

67 virtual void disconnect() OVERRIDE;	67 virtual void disconnect() OVERRIDE;

68	68

69 // WebSocketChannelClient	69 // WebSocketChannelClient

70 virtual void didConnect() OVERRIDE;	70 virtual void didConnect() OVERRIDE;

71 virtual void didReceiveMessage(const String& message) OVERRIDE;	71 virtual void didReceiveMessage(const String& message) OVERRIDE;

72 virtual void didReceiveBinaryData(PassOwnPtr<Vector<char> > binaryData) OVER RIDE;	72 virtual void didReceiveBinaryData(PassOwnPtr<Vector<char> > binaryData) OVER RIDE;

73 virtual void didReceiveMessageError() OVERRIDE;	73 virtual void didReceiveMessageError() OVERRIDE;

74 virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) OVERRIDE;	74 virtual void didIncreaseBufferedAmount(unsigned long amount) OVERRIDE;

	75 virtual void didDecreaseBufferedAmount(unsigned long amount) OVERRIDE;

75 virtual void didStartClosingHandshake() OVERRIDE;	76 virtual void didStartClosingHandshake() OVERRIDE;

76 virtual void didClose(unsigned long bufferedAmount, ClosingHandshakeCompleti onStatus, unsigned short code, const String& reason) OVERRIDE;	77 virtual void didClose(unsigned long bufferedAmount, ClosingHandshakeCompleti onStatus, unsigned short code, const String& reason) OVERRIDE;

77	78

78 private:	79 private:

79 RefPtrWillBePersistent<WebCore::WebSocketChannel> m_private;	80 RefPtrWillBePersistent<WebCore::WebSocketChannel> m_private;

80 WebSocketClient* m_client;	81 WebSocketClient* m_client;

81 BinaryType m_binaryType;	82 BinaryType m_binaryType;

82 };	83 };

83	84

84 } // namespace blink	85 } // namespace blink

85	86

86 #endif // WebWebSocketChannelImpl_h	87 #endif // WebWebSocketChannelImpl_h

OLD	NEW