Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 311963002: In class Function replace current code field with current instruction field, that way we save one l… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 36916)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -591,8 +591,7 @@
__ popl(ECX); // Restore IC data.
__ LeaveFrame();
- __ movl(EBX, FieldAddress(EAX, Function::code_offset()));
- __ movl(EBX, FieldAddress(EBX, Code::instructions_offset()));
+ __ movl(EBX, FieldAddress(EAX, Function::instructions_offset()));
__ addl(EBX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
__ jmp(EBX);
}
@@ -1416,8 +1415,7 @@
__ Bind(&call_target_function);
// EAX: Target function.
- __ movl(EBX, FieldAddress(EAX, Function::code_offset()));
- __ movl(EBX, FieldAddress(EBX, Code::instructions_offset()));
+ __ movl(EBX, FieldAddress(EAX, Function::instructions_offset()));
__ addl(EBX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
__ jmp(EBX);
@@ -1565,10 +1563,9 @@
// Get function and call it, if possible.
__ movl(EAX, Address(EBX, target_offset));
- __ movl(EBX, FieldAddress(EAX, Function::code_offset()));
+ __ movl(EBX, FieldAddress(EAX, Function::instructions_offset()));
- // EBX: Target code.
- __ movl(EBX, FieldAddress(EBX, Code::instructions_offset()));
+ // EBX: Target instructions.
__ addl(EBX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
__ jmp(EBX);
}
@@ -1596,8 +1593,7 @@
__ popl(EDX); // Restore arguments descriptor array.
__ LeaveFrame();
- __ movl(EAX, FieldAddress(EAX, Function::code_offset()));
- __ movl(EAX, FieldAddress(EAX, Code::instructions_offset()));
+ __ movl(EAX, FieldAddress(EAX, Function::instructions_offset()));
__ addl(EAX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
__ jmp(EAX);
}
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698