runtime/vm/gc_marker.cc - Issue 311963002: In class Function replace current code field with current instruction field, that way we save one l…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 311963002: In class Function replace current code field with current instruction field, that way we save one l… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/gc_marker.cc

===================================================================

--- runtime/vm/gc_marker.cc (revision 36916)

+++ runtime/vm/gc_marker.cc (working copy)

@@ -244,12 +244,13 @@

void DetachCode() {

for (int i = 0; i < skipped_code_functions_.length(); i++) {

RawFunction* func = skipped_code_functions_[i];

- RawCode* code = func->ptr()->code_;

+ RawCode* code = func->ptr()->instructions_->ptr()->code_;

if (!code->IsMarked()) {

// If the code wasn't strongly visited through other references

// after skipping the function's code pointer, then we disconnect the

// code from the function.

- func->ptr()->code_ = StubCode::LazyCompile_entry()->code();

+ func->ptr()->instructions_ =

+ StubCode::LazyCompile_entry()->code()->ptr()->instructions_;

func->ptr()->unoptimized_code_ = Code::null();

if (FLAG_log_code_drop) {

// NOTE: This code runs while GC is in progress and runs within

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »